Issue 1993083002: The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a red…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1993083002: The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a red… (Closed)

Created:
4 years, 7 months ago by hubbe

Modified:
4 years, 7 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2704

Target Ref:
refs/pending/branch-heads/2704

Project:
chromium

Visibility:
Public.

The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a redirect happens. Service-workers do not need redirects to paste data from diffierent origins together. This CL fixes that. BUG=610747 Committed: https://chromium.googlesource.com/chromium/src/+/87f5415ae750e78664b6f50812bd3fe36665a9fe

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+101 lines, -28 lines)			Patch
M	media/blink/multibuffer_data_source.cc	View	1 chunk	+3 lines, -5 lines	0 comments	Download
M	media/blink/multibuffer_data_source_unittest.cc	View	9 chunks	+42 lines, -8 lines	0 comments	Download
M	media/blink/resource_multibuffer_data_provider.cc	View	4 chunks	+16 lines, -3 lines	0 comments	Download
M	media/blink/resource_multibuffer_data_provider_unittest.cc	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	media/blink/url_index.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	media/blink/url_index.cc	View	3 chunks	+25 lines, -9 lines	0 comments	Download
M	third_party/WebKit/LayoutTests/http/tests/serviceworker/chromium/service-worker-mixed-response.html	View	2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

hubbe

4 years, 7 months ago (2016-05-18 23:45:20 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
87f5415ae750e78664b6f50812bd3fe36665a9fe.