Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1131)

Unified Diff: media/blink/resource_multibuffer_data_provider_unittest.cc

Issue 1993083002: The cross-origin checks in the multibuffer code are not sufficient, as they only trigger when a red… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/blink/resource_multibuffer_data_provider.cc ('k') | media/blink/url_index.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/blink/resource_multibuffer_data_provider_unittest.cc
diff --git a/media/blink/resource_multibuffer_data_provider_unittest.cc b/media/blink/resource_multibuffer_data_provider_unittest.cc
index 1055a2b0fcf834eb8b94117e8eaea3285cca4eea..413b1b6e543b6e34cf1e27dc4956de386437b9ed 100644
--- a/media/blink/resource_multibuffer_data_provider_unittest.cc
+++ b/media/blink/resource_multibuffer_data_provider_unittest.cc
@@ -254,7 +254,6 @@ TEST_F(ResourceMultiBufferDataProviderTest, BadHttpResponse) {
response.setHTTPStatusCode(404);
response.setHTTPStatusText("Not Found\n");
loader_->didReceiveResponse(url_loader_, response);
- StopWhenLoad();
}
// Tests that partial content is requested but not fulfilled.
@@ -262,7 +261,6 @@ TEST_F(ResourceMultiBufferDataProviderTest, NotPartialResponse) {
Initialize(kHttpUrl, 100);
Start();
FullResponse(1024, false);
- StopWhenLoad();
}
// Tests that a 200 response is received.
@@ -319,7 +317,6 @@ TEST_F(ResourceMultiBufferDataProviderTest, InvalidPartialResponse) {
response.setExpectedContentLength(10);
response.setHTTPStatusCode(kHttpPartialContent);
loader_->didReceiveResponse(url_loader_, response);
- StopWhenLoad();
}
TEST_F(ResourceMultiBufferDataProviderTest, TestRedirects) {
« no previous file with comments | « media/blink/resource_multibuffer_data_provider.cc ('k') | media/blink/url_index.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698