Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1993073003: [turbofan] Implement intrinsic lowering of %_GeneratorClose. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@gen-turbo
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Implement intrinsic lowering of %_GeneratorClose. Also change parser to insert %_GeneratorClose instead of %GeneratorClose. Full-codegen generators will fall back to the runtime function. BUG=v8:4907 Committed: https://crrev.com/b3ae02e8e4db679a937acc93419b5c6d82d68726 Cr-Commit-Position: refs/heads/master@{#36401}

Patch Set 1 #

Patch Set 2 : bytecode expectations rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -5 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/interpreter/bytecode_expectations/Generators.golden View 1 3 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 24 (13 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993073003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993073003/1
4 years, 7 months ago (2016-05-19 14:44:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993073003/20001
4 years, 7 months ago (2016-05-19 14:46:22 UTC) #5
neis
PTAL I changed the parser to insert %_GeneratorClose instead of %GeneratorClose. Note that full-codegen generators ...
4 years, 7 months ago (2016-05-19 15:15:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 15:17:05 UTC) #9
Benedikt Meurer
lgtm
4 years, 7 months ago (2016-05-19 17:25:47 UTC) #10
Jarin
lgtm
4 years, 7 months ago (2016-05-19 18:52:51 UTC) #11
neis
On 2016/05/19 18:52:51, Jarin wrote: > lgtm rossberg parser please
4 years, 7 months ago (2016-05-20 08:52:34 UTC) #17
rossberg
On 2016/05/20 08:52:34, neis wrote: > On 2016/05/19 18:52:51, Jarin wrote: > > lgtm > ...
4 years, 7 months ago (2016-05-20 09:08:47 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993073003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993073003/20001
4 years, 7 months ago (2016-05-20 09:38:30 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-20 09:40:29 UTC) #22
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 09:41:30 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b3ae02e8e4db679a937acc93419b5c6d82d68726
Cr-Commit-Position: refs/heads/master@{#36401}

Powered by Google App Engine
This is Rietveld 408576698