Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1991203002: [generators] Replace some runtime functions with Turbofan JS operators. (Closed)

Created:
4 years, 7 months ago by neis
Modified:
4 years, 7 months ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[generators] Replace some runtime functions with Turbofan JS operators. Introduce three new JS operators in Turbofan: - JSGeneratorStore is used in implementing Ignition's SuspendGenerator bytecode. - JSGeneratorRestoreContinuation and JSGeneratorRestoreRegister are used in implementing Ignition's ResumeGenerator bytecode. Remove the runtime functions that were used to implement these bytecodes before. BUG=v8:4907 Committed: https://crrev.com/29f3e6682b44b898cece150e07e6f04f5461aaf0 Cr-Commit-Position: refs/heads/master@{#36395}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -116 lines) Patch
M src/compiler/access-builder.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +34 lines, -0 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 2 chunks +14 lines, -17 lines 0 comments Download
M src/compiler/graph-reducer.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/js-operator.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/js-operator.cc View 2 chunks +44 lines, -28 lines 0 comments Download
M src/compiler/js-typed-lowering.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +104 lines, -0 lines 0 comments Download
M src/compiler/linkage.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +14 lines, -11 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +1 line, -5 lines 0 comments Download
M src/runtime/runtime-generator.cc View 2 chunks +0 lines, -49 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991203002/1
4 years, 7 months ago (2016-05-19 12:57:32 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-19 13:35:07 UTC) #4
neis
PTAL
4 years, 7 months ago (2016-05-19 13:46:32 UTC) #8
Jarin
I like it, lgtm!
4 years, 7 months ago (2016-05-19 19:02:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991203002/1
4 years, 7 months ago (2016-05-20 08:27:09 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-20 08:29:54 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-20 08:30:41 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29f3e6682b44b898cece150e07e6f04f5461aaf0
Cr-Commit-Position: refs/heads/master@{#36395}

Powered by Google App Engine
This is Rietveld 408576698