Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 1993063003: Revert of Mojo C++ bindings: make StrongBinding a message loop destruction observer. (Closed)

Created:
4 years, 7 months ago by yzshen1
Modified:
4 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mojo C++ bindings: make StrongBinding a message loop destruction observer. (patchset #2 id:20001 of https://codereview.chromium.org/1913333002/ ) Reason for revert: As discussed in the mailing thread, I am thinking to do destruction observation at the router level instead. Original issue's description: > Mojo C++ bindings: make StrongBinding a message loop destruction observer. > > This is a preparation for removing message loop destruction observer from mojo::Watcher. > > BUG=604762 > > Committed: https://crrev.com/3f9ef16903199e305ae2ffb3fe74fcdd48e2ded0 > Cr-Commit-Position: refs/heads/master@{#389803} TBR=rockot@chromium.org,jam@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=604762 Committed: https://crrev.com/ba42c515d544ebd6922b1f6064da20f6ac7ecbd4 Cr-Commit-Position: refs/heads/master@{#394635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -35 lines) Patch
M chrome/utility/image_decoder_impl_unittest.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M mojo/public/cpp/bindings/strong_binding.h View 4 chunks +12 lines, -25 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
yzshen1
Created Revert of Mojo C++ bindings: make StrongBinding a message loop destruction observer.
4 years, 7 months ago (2016-05-18 23:39:07 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-18 23:40:00 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-19 00:02:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-19 00:32:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-19 01:02:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-19 01:32:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1993063003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1993063003/1
4 years, 7 months ago (2016-05-19 02:01:49 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 02:05:33 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 02:06:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba42c515d544ebd6922b1f6064da20f6ac7ecbd4
Cr-Commit-Position: refs/heads/master@{#394635}

Powered by Google App Engine
This is Rietveld 408576698