Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: chrome/utility/image_decoder_impl_unittest.cc

Issue 1993063003: Revert of Mojo C++ bindings: make StrongBinding a message loop destruction observer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/strong_binding.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/image_decoder_impl_unittest.cc
diff --git a/chrome/utility/image_decoder_impl_unittest.cc b/chrome/utility/image_decoder_impl_unittest.cc
index 5a83eed2afdfad8ac0557f20ac94b5f5d28cc4de..45f257c8699d5258d85c293186315bbe882d7369 100644
--- a/chrome/utility/image_decoder_impl_unittest.cc
+++ b/chrome/utility/image_decoder_impl_unittest.cc
@@ -7,7 +7,6 @@
#include <vector>
#include "base/bind.h"
-#include "base/message_loop/message_loop.h"
#include "ipc/ipc_channel.h"
#include "skia/public/type_converters.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -58,17 +57,10 @@
skia::mojom::BitmapPtr bitmap_;
};
-class ImageDecoderImplTest : public testing::Test {
- protected:
- ~ImageDecoderImplTest() override {}
-
- base::MessageLoop message_loop_;
-};
-
} // namespace
// Test that DecodeImage() doesn't return image message > (max message size)
-TEST_F(ImageDecoderImplTest, DecodeImageSizeLimit) {
+TEST(ImageDecoderImplTest, DecodeImageSizeLimit) {
// Using actual limit generates 14000 x 9400 images, which causes the test to
// timeout. We test with a smaller limit for efficiency.
const size_t kTestMessageSize = IPC::Channel::kMaximumMessageSize / 1024;
@@ -114,7 +106,7 @@
}
}
-TEST_F(ImageDecoderImplTest, DecodeImageFailed) {
+TEST(ImageDecoderImplTest, DecodeImageFailed) {
ImageDecoderImpl decoder(IPC::Channel::kMaximumMessageSize);
// The "jpeg" is just some "random" data;
« no previous file with comments | « no previous file | mojo/public/cpp/bindings/strong_binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698