Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Unified Diff: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
diff --git a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
index 188e1766ff57082a5a8052d4e229cf31ecd957dc..59340bc2dbfa4f1be285065bb6a4e8b8c734489e 100644
--- a/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
+++ b/components/cronet/android/java/src/org/chromium/net/CronetBidirectionalStream.java
@@ -71,6 +71,7 @@ class CronetBidirectionalStream extends BidirectionalStream {
private final String mInitialMethod;
private final String mRequestHeaders[];
private final boolean mDisableAutoFlush;
+ private final boolean mDelayHeadersUntilNextWrite;
/*
* Synchronizes access to mNativeStream, mReadState and mWriteState.
@@ -202,7 +203,7 @@ class CronetBidirectionalStream extends BidirectionalStream {
CronetBidirectionalStream(CronetUrlRequestContext requestContext, String url,
@BidirectionalStream.Builder.StreamPriority int priority, Callback callback,
Executor executor, String httpMethod, List<Map.Entry<String, String>> requestHeaders,
- boolean disableAutoFlush) {
+ boolean disableAutoFlush, boolean delayHeadersUntilNextWrite) {
mRequestContext = requestContext;
mInitialUrl = url;
mInitialPriority = convertStreamPriority(priority);
@@ -211,6 +212,7 @@ class CronetBidirectionalStream extends BidirectionalStream {
mInitialMethod = httpMethod;
mRequestHeaders = stringsFromHeaderList(requestHeaders);
mDisableAutoFlush = disableAutoFlush;
+ mDelayHeadersUntilNextWrite = delayHeadersUntilNextWrite;
mPendingData = new LinkedList<>();
mFlushData = new LinkedList<>();
}
@@ -223,7 +225,7 @@ class CronetBidirectionalStream extends BidirectionalStream {
}
try {
mNativeStream = nativeCreateBidirectionalStream(
- mRequestContext.getUrlRequestContextAdapter(), mDisableAutoFlush);
mef 2016/05/23 14:57:26 Is mDisableAutoFlush not used now?
+ mRequestContext.getUrlRequestContextAdapter(), mDelayHeadersUntilNextWrite);
mRequestContext.onRequestStarted();
// Non-zero startResult means an argument error.
int startResult = nativeStart(mNativeStream, mInitialUrl, mInitialPriority,
@@ -688,7 +690,7 @@ class CronetBidirectionalStream extends BidirectionalStream {
// Native methods are implemented in cronet_bidirectional_stream_adapter.cc.
private native long nativeCreateBidirectionalStream(
- long urlRequestContextAdapter, boolean disableAutoFlush);
+ long urlRequestContextAdapter, boolean delayHeadersUntilNextWrite);
@NativeClassQualifiedName("CronetBidirectionalStreamAdapter")
private native int nativeStart(long nativePtr, String url, int priority, String method,

Powered by Google App Engine
This is Rietveld 408576698