Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1006)

Unified Diff: components/cronet/android/cronet_bidirectional_stream_adapter.cc

Issue 1992953004: [Cronet] Make delaying sending request headers explicit in bidirectional stream (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: self review Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/cronet_bidirectional_stream_adapter.cc
diff --git a/components/cronet/android/cronet_bidirectional_stream_adapter.cc b/components/cronet/android/cronet_bidirectional_stream_adapter.cc
index 60629be19c64055da7aed88b4ffa14f4b2074a02..843c94ec7fbe1dfc7f0c31a48e85b4a0c0802a9b 100644
--- a/components/cronet/android/cronet_bidirectional_stream_adapter.cc
+++ b/components/cronet/android/cronet_bidirectional_stream_adapter.cc
@@ -71,7 +71,7 @@ static jlong CreateBidirectionalStream(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& jbidi_stream,
jlong jurl_request_context_adapter,
- jboolean jdisable_auto_flush) {
+ jboolean jdelay_headers_until_next_send_data) {
CronetURLRequestContextAdapter* context_adapter =
reinterpret_cast<CronetURLRequestContextAdapter*>(
jurl_request_context_adapter);
@@ -79,7 +79,7 @@ static jlong CreateBidirectionalStream(
CronetBidirectionalStreamAdapter* adapter =
new CronetBidirectionalStreamAdapter(context_adapter, env, jbidi_stream,
- jdisable_auto_flush);
+ jdelay_headers_until_next_send_data);
return reinterpret_cast<jlong>(adapter);
}
@@ -93,10 +93,10 @@ CronetBidirectionalStreamAdapter::CronetBidirectionalStreamAdapter(
CronetURLRequestContextAdapter* context,
JNIEnv* env,
const base::android::JavaParamRef<jobject>& jbidi_stream,
- bool disable_auto_flush)
+ bool delay_headers_until_next_send_data)
: context_(context),
owner_(env, jbidi_stream),
- disable_auto_flush_(disable_auto_flush),
+ delay_headers_until_next_send_data_(delay_headers_until_next_send_data),
stream_failed_(false) {}
CronetBidirectionalStreamAdapter::~CronetBidirectionalStreamAdapter() {
@@ -321,7 +321,7 @@ void CronetBidirectionalStreamAdapter::StartOnNetworkThread(
std::move(request_info), context_->GetURLRequestContext()
->http_transaction_factory()
->GetSession(),
- disable_auto_flush_, this));
+ delay_headers_until_next_send_data_, this));
}
void CronetBidirectionalStreamAdapter::ReadDataOnNetworkThread(

Powered by Google App Engine
This is Rietveld 408576698