[DevTools] Move monitor/unmonitor events CommandLineAPI to native

third_party/WebKit/Source/core/inspector/ThreadDebugger.h

Index: third_party/WebKit/Source/core/inspector/ThreadDebugger.h
diff --git a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
index 1f9e1794454c1047f69c5781ddf3b906384a03d4..0b5f21520947c6ab3b28dd1b34bb0c63d1be6aee 100644
--- a/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
+++ b/third_party/WebKit/Source/core/inspector/ThreadDebugger.h
@@ -40,7 +40,8 @@ public:
     bool isExecutionAllowed() override;
     double currentTimeMS() override;
     bool isInspectableHeapObject(v8::Local<v8::Object>) override;
-    void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override { }
+    static bool isCommandLineAPIMethod(const String& name);
+    void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
     void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) final;
     void consoleTime(const String16& title) override;
     void consoleTimeEnd(const String16& title) override;
@@ -51,15 +52,26 @@ public:
     V8Debugger* debugger() const { return m_debugger.get(); }
     virtual bool isWorker() { return true; }
 protected:
+    void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name, v8::FunctionCallback, const char* description);
     virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;
     void onTimer(Timer<ThreadDebugger>*);
 
     v8::Isolate* m_isolate;
     OwnPtr<V8Debugger> m_debugger;
+
+private:
     Vector<OwnPtr<Timer<ThreadDebugger>>> m_timers;
     Vector<V8DebuggerClient::TimerCallback> m_timerCallbacks;
     Vector<void*> m_timerData;
     OwnPtr<UserGestureIndicator> m_userGestureIndicator;
+
+    v8::Local<v8::Function> eventLogFunction();
+    v8::Global<v8::Function> m_eventLogFunction;
+
+    static void setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>&, bool enabled);

[dgozman, 2016/05/20 22:12:04]

style: all functions should be declared before all members.

[kozy, 2016/05/20 22:42:17]

Done.

+    static void monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) { setMonitorEventsCallback(info, true); }

[dgozman, 2016/05/20 22:12:04]

style: only trivial function definitions are allowed in header.

[kozy, 2016/05/20 22:42:17]

Done.

+    static void unmonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) { setMonitorEventsCallback(info, false); }
+    static void logCallback(const v8::FunctionCallbackInfo<v8::Value>&);
 };
 
 } // namespace blink