[DevTools] Move monitor/unmonitor events CommandLineAPI to native

third_party/WebKit/Source/core/inspector/ThreadDebugger.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ThreadDebugger_h
 #define ThreadDebugger_h
 
 #include "core/CoreExport.h"
 #include "platform/Timer.h"
 #include "platform/UserGestureIndicator.h"
@@ skipping 22 matching lines @@
 
     // V8DebuggerClient implementation.
     void beginUserGesture() override;
     void endUserGesture() override;
     void eventListeners(v8::Local<v8::Value>, V8EventListenerInfoList&) override;
     String16 valueSubtype(v8::Local<v8::Value>) override;
     bool formatAccessorsAsProperties(v8::Local<v8::Value>) override;
     bool isExecutionAllowed() override;
     double currentTimeMS() override;
     bool isInspectableHeapObject(v8::Local<v8::Object>) override;
-    void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override { }
+    static bool isCommandLineAPIMethod(const String& name);
+    void installAdditionalCommandLineAPI(v8::Local<v8::Context>, v8::Local<v8::Object>) override;
     void reportMessageToConsole(v8::Local<v8::Context>, MessageType, MessageLevel, const String16& message, const v8::FunctionCallbackInfo<v8::Value>* arguments, unsigned skipArgumentCount) final;
     void consoleTime(const String16& title) override;
     void consoleTimeEnd(const String16& title) override;
     void consoleTimeStamp(const String16& title) override;
     void startRepeatingTimer(double, V8DebuggerClient::TimerCallback, void* data) override;
     void cancelTimer(void* data) override;
 
     V8Debugger* debugger() const { return m_debugger.get(); }
     virtual bool isWorker() { return true; }
 protected:
+    void createFunctionProperty(v8::Local<v8::Context>, v8::Local<v8::Object>, const char* name, v8::FunctionCallback, const char* description);
     virtual void reportMessageToConsole(v8::Local<v8::Context>, ConsoleMessage*) = 0;
     void onTimer(Timer<ThreadDebugger>*);
 
     v8::Isolate* m_isolate;
     OwnPtr<V8Debugger> m_debugger;
+
+private:
     Vector<OwnPtr<Timer<ThreadDebugger>>> m_timers;
     Vector<V8DebuggerClient::TimerCallback> m_timerCallbacks;
     Vector<void*> m_timerData;
     OwnPtr<UserGestureIndicator> m_userGestureIndicator;
+
+    v8::Local<v8::Function> eventLogFunction();
+    v8::Global<v8::Function> m_eventLogFunction;
+
+    static void setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>&, bool enabled);

[dgozman, 2016/05/20 22:12:04]

style: all functions should be declared before all members.

[kozy, 2016/05/20 22:42:17]

Done.

+    static void monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) { setMonitorEventsCallback(info, true); }

[dgozman, 2016/05/20 22:12:04]

style: only trivial function definitions are allowed in header.

[kozy, 2016/05/20 22:42:17]

Done.

+    static void unmonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) { setMonitorEventsCallback(info, false); }
+    static void logCallback(const v8::FunctionCallbackInfo<v8::Value>&);
 };
 
 } // namespace blink
 
 #endif // ThreadDebugger_h