[DevTools] Move monitor/unmonitor events CommandLineAPI to native

[DevTools] Move monitor/unmonitor events CommandLineAPI to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e
Cr-Commit-Position: refs/heads/master@{#395236}

[kozy, 2016-05-19 21:18:41]

Dmitry, please take a look!

[kozy, 2016-05-20 00:54:56]

Patchset #3 (id:40001) has been deleted

[dgozman, 2016-05-20 22:12:04]

lgtm

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:162: v8::Isolate*
isolate = info.GetIsolate();
nit: inline this.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:203: if (!debugger)
DCHECK(debugger)

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:212:
Vector<ScriptValue> arguments = Vector<ScriptValue>({
Is this the right formatting? Looks strange, but I'm not sure how it's supposed
to be.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:235: if
(EventTarget* target =  V8EventTarget::toImplWithTypeCheck(info.GetIsolate(),
info[0]))
style: two spaces after =

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.h (right):

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.h:71: static void
setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>&, bool
enabled);
style: all functions should be declared before all members.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.h:72: static void
monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
setMonitorEventsCallback(info, true); }
style: only trivial function definitions are allowed in header.

[kozy, 2016-05-20 22:40:28]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-05-20 22:40:29]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1992913006/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-05-20 22:40:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992913006/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992913006/120001

[kozy, 2016-05-20 22:42:17]

All done

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp (right):

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:162: v8::Isolate*
isolate = info.GetIsolate();
On 2016/05/20 22:12:04, dgozman wrote:
> nit: inline this.

Done.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:203: if (!debugger)
On 2016/05/20 22:12:04, dgozman wrote:
> DCHECK(debugger)

Done.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:212:
Vector<ScriptValue> arguments = Vector<ScriptValue>({
On 2016/05/20 22:12:04, dgozman wrote:
> Is this the right formatting? Looks strange, but I'm not sure how it's
supposed
> to be.

Acknowledged.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.cpp:235: if
(EventTarget* target =  V8EventTarget::toImplWithTypeCheck(info.GetIsolate(),
info[0]))
On 2016/05/20 22:12:04, dgozman wrote:
> style: two spaces after =

Done.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/ThreadDebugger.h (right):

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.h:71: static void
setMonitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>&, bool
enabled);
On 2016/05/20 22:12:04, dgozman wrote:
> style: all functions should be declared before all members.

Done.

https://codereview.chromium.org/1992913006/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/ThreadDebugger.h:72: static void
monitorEventsCallback(const v8::FunctionCallbackInfo<v8::Value>& info) {
setMonitorEventsCallback(info, true); }
On 2016/05/20 22:12:04, dgozman wrote:
> style: only trivial function definitions are allowed in header.

Done.

[commit-bot: I haz the power, 2016-05-21 02:48:39]

Committed patchset #6 (id:120001)

[commit-bot: I haz the power, 2016-05-21 02:50:27]

Description was changed from

==========
[DevTools] Move monitor/unmonitor events CommandLineAPI to native

BUG=595206
R=dgozman@chromium.org
==========

to

==========
[DevTools] Move monitor/unmonitor events CommandLineAPI to native

BUG=595206
R=dgozman@chromium.org

Committed: https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e
Cr-Commit-Position: refs/heads/master@{#395236}
==========

[commit-bot: I haz the power, 2016-05-21 02:50:28]

Patchset 6 (id:??) landed as
https://crrev.com/3a8dc0e8677283c2f752c254ccd4c77059c18c1e
Cr-Commit-Position: refs/heads/master@{#395236}