Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1047)

Issue 1992913002: [merged] Report media error if PlayOutputBuffer failed (Closed)

Created:
4 years, 7 months ago by Tima Vaisburd
Modified:
4 years, 7 months ago
Reviewers:
timav
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

[merged] Report media error if PlayOutputBuffer failed Replace CHECK_EQ with a proper error reporting in MediaSourcePlayer and MediaCodecPlayer. This CL completes https://codereview.chromium.org/1764813002. For MediaSourcePlayer we report the error through the status that is passed with DecoderCallback. For MediaCodecPlayer the decoder's method Render() now returns bool. BUG=585978, 606061 TBR=timav > Review-Url: https://codereview.chromium.org/1963343002 > Cr-Commit-Position: refs/heads/master@{#393124} Committed: https://chromium.googlesource.com/chromium/src/+/b1986ad6ff280f97d0965265156eb9c6731fa55f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -91 lines) Patch
M media/base/android/audio_decoder_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/base/android/audio_decoder_job.cc View 2 chunks +42 lines, -35 lines 0 comments Download
M media/base/android/audio_media_codec_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/audio_media_codec_decoder.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M media/base/android/media_codec_decoder.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/base/android/media_codec_decoder.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M media/base/android/media_decoder_job.h View 2 chunks +2 lines, -8 lines 0 comments Download
M media/base/android/media_decoder_job.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M media/base/android/sdk_media_codec_bridge.cc View 1 chunk +4 lines, -1 line 0 comments Download
M media/base/android/video_decoder_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M media/base/android/video_decoder_job.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M media/base/android/video_media_codec_decoder.h View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/video_media_codec_decoder.cc View 4 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Tima Vaisburd
4 years, 7 months ago (2016-05-18 18:24:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b1986ad6ff280f97d0965265156eb9c6731fa55f.

Powered by Google App Engine
This is Rietveld 408576698