third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp - Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp

Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Specialized dchecks in utils.h. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/wtf/dtoa/utils.h ('K') | « third_party/WebKit/Source/wtf/text/StringImpl.cpp ('k') | third_party/WebKit/Source/wtf/text/WTFString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp

diff --git a/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp b/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp

index 6fc1f15a2df3867d4294cf5e13e0b588cf4c266e..7e63eb05ef93b034a4a607b994c18b0201445d67 100644

--- a/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp

+++ b/third_party/WebKit/Source/wtf/text/TextCodecUTF16.cpp

@@ -166,7 +166,7 @@ CString TextCodecUTF16::encode(const UChar* characters, size_t length, Unencodab

CString TextCodecUTF16::encode(const LChar* characters, size_t length, UnencodableHandling)

{

// In the LChar case, we do actually need to perform this check in release. :)

- RELEASE_ASSERT(length <= numeric_limits<size_t>::max() / 2);

+ CHECK_LE(length, numeric_limits<size_t>::max() / 2);

char* bytes;

CString result = CString::newUninitialized(length * 2, bytes);