Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1700)

Unified Diff: third_party/WebKit/Source/wtf/dtoa/utils.h

Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Specialized dchecks in utils.h. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/dtoa/utils.h
diff --git a/third_party/WebKit/Source/wtf/dtoa/utils.h b/third_party/WebKit/Source/wtf/dtoa/utils.h
index dcc433f1ba3fd64130546a554a4d0ff283542244..da2ba8055a95640e02ad42a7500e4b399e21ad81 100644
--- a/third_party/WebKit/Source/wtf/dtoa/utils.h
+++ b/third_party/WebKit/Source/wtf/dtoa/utils.h
@@ -165,7 +165,8 @@ namespace double_conversion {
// Access individual vector elements.
T& operator[](int index) const {
- RELEASE_ASSERT(0 <= index && index < length_);
+ CHECK_LE(0, index);
danakj 2016/06/01 18:20:11 It's a long shot but this isn't just a replacement
kotenkov 2016/06/01 18:22:39 Hmm, I'll run perf try jobs later today.
+ CHECK_LT(index, length_);
return start_[index];
}
« no previous file with comments | « third_party/WebKit/Source/wtf/allocator/Partitions.cpp ('k') | third_party/WebKit/Source/wtf/text/AtomicString.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698