Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.h

Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Specialized dchecks in utils.h. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringImpl.h
diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.h b/third_party/WebKit/Source/wtf/text/StringImpl.h
index 161fa19be061c9ad496f7190c45a2f565eda7fc0..eaf077a7371ca90940ca996c9327900bc18c478d 100644
--- a/third_party/WebKit/Source/wtf/text/StringImpl.h
+++ b/third_party/WebKit/Source/wtf/text/StringImpl.h
@@ -424,7 +424,7 @@ public:
private:
template<typename CharType> static size_t allocationSize(unsigned length)
{
- RELEASE_ASSERT(length <= ((std::numeric_limits<unsigned>::max() - sizeof(StringImpl)) / sizeof(CharType)));
+ CHECK_LE(length, (std::numeric_limits<unsigned>::max() - sizeof(StringImpl)) / sizeof(CharType));
return sizeof(StringImpl) + length * sizeof(CharType);
}
@@ -658,7 +658,7 @@ inline unsigned lengthOfNullTerminatedString(const UChar* string)
size_t length = 0;
while (string[length] != UChar(0))
++length;
- RELEASE_ASSERT(length <= std::numeric_limits<unsigned>::max());
+ CHECK_LE(length, std::numeric_limits<unsigned>::max());
return static_cast<unsigned>(length);
}

Powered by Google App Engine
This is Rietveld 408576698