Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: third_party/WebKit/Source/wtf/text/StringConcatenate.h

Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Specialized dchecks in utils.h. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/wtf/text/StringConcatenate.h
diff --git a/third_party/WebKit/Source/wtf/text/StringConcatenate.h b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
index 63a7c4e296292295007d7a15bff37fa10dac4e9e..10d970a52cb39d154021bc5b82f224920097b114 100644
--- a/third_party/WebKit/Source/wtf/text/StringConcatenate.h
+++ b/third_party/WebKit/Source/wtf/text/StringConcatenate.h
@@ -171,9 +171,13 @@ public:
bool is8Bit() { return false; }
+#if defined(OFFICIAL_BUILD) && defined(NDEBUG)
NO_RETURN_DUE_TO_CRASH void writeTo(LChar*)
+#else
+ void writeTo(LChar*)
+#endif
{
- RELEASE_ASSERT(false);
+ CHECK(false);
}
void writeTo(UChar* destination);

Powered by Google App Engine
This is Rietveld 408576698