Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

third_party/WebKit/Source/wtf/dtoa/utils.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 147 matching lines @@
         int length() const { return length_; }
 
         // Returns whether or not the vector is empty.
         bool is_empty() const { return length_ == 0; }
 
         // Returns the pointer to the start of the data in the vector.
         T* start() const { return start_; }
 
         // Access individual vector elements.
         T& operator[](int index) const {
-            RELEASE_ASSERT(0 <= index && index < length_);
+            CHECK_LE(0, index);

[danakj, 2016/06/01 18:20:11]

It's a long shot but this isn't just a replacement of RELEASE_ASSERT with CHECK
since it uses 2 RELEASE_ASSERTs now essentially. Any chance this is the perf
regression?

[kotenkov, 2016/06/01 18:22:39]

Hmm, I'll run perf try jobs later today.

+            CHECK_LT(index, length_);
             return start_[index];
         }
 
         T& first() { return start_[0]; }
 
         T& last() { return start_[length_ - 1]; }
 
     private:
         T* start_;
         int length_;
@@ skipping 121 matching lines @@
     template <class Dest, class Source>
     inline Dest BitCast(Source* source) {
         return BitCast<Dest>(reinterpret_cast<uintptr_t>(source));
     }
 
 }  // namespace double_conversion
 
 } // namespace WTF
 
 #endif  // DOUBLE_CONVERSION_UTILS_H_