third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h - Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h

Issue 1992873004: Replace all occurrences of RELEASE_ASSERT in wtf with CHECK. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Specialized dchecks in utils.h. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h

diff --git a/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h b/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h

index a7ec3305a77d0bdde0389d648d49bc8bdc4077a3..d5c3dc69d8c67869a1c911a6878c500c3507bea8 100644

--- a/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h

+++ b/third_party/WebKit/Source/wtf/TerminatedArrayBuilder.h

@@ -43,7 +43,7 @@ public:

void append(const T& item)

{

- RELEASE_ASSERT(m_count < m_capacity);

+ CHECK_LT(m_count, m_capacity);

ASSERT(!item.isLastInArray());

m_array->at(m_count++) = item;

if (m_count == m_capacity)

@@ -52,7 +52,7 @@ public:

typename ArrayType<T>::Allocator::PassPtr release()

{

- RELEASE_ASSERT(m_count == m_capacity);

+ CHECK_EQ(m_count, m_capacity);

assertValid();

return ArrayType<T>::Allocator::release(m_array);

}

« no previous file with comments | « third_party/WebKit/Source/wtf/HashTable.h ('k') | third_party/WebKit/Source/wtf/Vector.h » ('j') | third_party/WebKit/Source/wtf/dtoa/utils.h » ('J')