Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 199273005: Oilpan: Change the name of the finalization method that can be (Closed)

Created:
6 years, 9 months ago by Mads Ager (chromium)
Modified:
6 years, 9 months ago
CC:
blink-reviews, ed+blinkwatch_opera.com, Mikhail, abarth-chromium, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, rune+blink, kouhei+heap_chromium.org, Inactive, rwlbuis
Visibility:
Public.

Description

Oilpan: Change the name of the finalization method that can be overridden for explicit destructor dispatching. The |finalize| name is too short and makes sense in other places in the code. We rarely need to override finalizeGarbageCollectedObject so it is fine that the method name is long. Concretely, fileapi Stream has a finalize method that currently gets called instead of the destructor. That leads to crashes because the Stream destructor is not called and therefore the Stream is no unregistered as a ContextLifecycleObserver and a call is made on the already dead stream when the Document dies. R=erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, zerny@chromium.org BUG=352755 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169548

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M Source/core/css/CSSValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StylePropertySet.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRule.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/StyleRule.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/heap/Heap.h View 1 chunk +8 lines, -6 lines 0 comments Download
M Source/heap/HeapTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/heap/Visitor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/wtf/Vector.h View 1 chunk +5 lines, -0 lines 2 comments Download

Messages

Total messages: 14 (0 generated)
Mads Ager (chromium)
6 years, 9 months ago (2014-03-19 12:24:33 UTC) #1
haraken
LGTM
6 years, 9 months ago (2014-03-19 12:26:05 UTC) #2
Mads Ager (chromium)
Jochen or Kent, could you stamp wtf/Vector.h change?
6 years, 9 months ago (2014-03-19 12:37:59 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 9 months ago (2014-03-19 12:39:27 UTC) #4
Mads Ager (chromium)
On 2014/03/19 12:39:27, jochen wrote: > lgtm Thanks Jochen! :)
6 years, 9 months ago (2014-03-19 12:39:52 UTC) #5
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-19 12:39:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/199273005/1
6 years, 9 months ago (2014-03-19 12:39:58 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-19 12:42:11 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 9 months ago (2014-03-19 12:42:11 UTC) #9
Mads Ager (chromium)
The CQ bit was checked by ager@chromium.org
6 years, 9 months ago (2014-03-19 12:46:50 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ager@chromium.org/199273005/1
6 years, 9 months ago (2014-03-19 12:47:01 UTC) #11
commit-bot: I haz the power
Change committed as 169548
6 years, 9 months ago (2014-03-19 13:45:39 UTC) #12
zerny-chromium
QQ https://codereview.chromium.org/199273005/diff/1/Source/wtf/Vector.h File Source/wtf/Vector.h (right): https://codereview.chromium.org/199273005/diff/1/Source/wtf/Vector.h#newcode612 Source/wtf/Vector.h:612: finalize(); Is there a particular reason finalize is ...
6 years, 9 months ago (2014-03-21 07:21:01 UTC) #13
Mads Ager (google)
6 years, 9 months ago (2014-03-21 07:26:38 UTC) #14
Message was sent while issue was closed.
https://codereview.chromium.org/199273005/diff/1/Source/wtf/Vector.h
File Source/wtf/Vector.h (right):

https://codereview.chromium.org/199273005/diff/1/Source/wtf/Vector.h#newcode612
Source/wtf/Vector.h:612: finalize();
On 2014/03/21 07:21:01, zerny-chromium wrote:
> Is there a particular reason finalize is not renamed here?

Yeah, finalize is also called in the non-oilpan build.

Powered by Google App Engine
This is Rietveld 408576698