Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: Source/heap/Heap.h

Issue 199273005: Oilpan: Change the name of the finalization method that can be (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/heap/Heap.h
diff --git a/Source/heap/Heap.h b/Source/heap/Heap.h
index f7f5b6b452b4cda0cf65920f46bdc91017603af0..2dc8cbeaa34673f142ea414af1f6fd846ead2814 100644
--- a/Source/heap/Heap.h
+++ b/Source/heap/Heap.h
@@ -918,12 +918,14 @@ class GarbageCollectedFinalized : public GarbageCollected<T> {
WTF_MAKE_NONCOPYABLE(GarbageCollectedFinalized);
protected:
- // Finalize is called when the object is freed from the heap. By
- // default finalization means calling the destructor on the
- // object. Finalize can be overridden to support calling the
- // destructor of a subclass. This is useful for objects without
- // vtables that require explicit dispatching.
- void finalize()
+ // finalizeGarbageCollectedObject is called when the object is
+ // freed from the heap. By default finalization means calling the
+ // destructor on the object. finalizeGarbageCollectedObject can be
+ // overridden to support calling the destructor of a
+ // subclass. This is useful for objects without vtables that
+ // require explicit dispatching. The name is intentionally a bit
+ // long to make name conflicts less likely.
+ void finalizeGarbageCollectedObject()
{
static_cast<T*>(this)->~T();
}
« no previous file with comments | « Source/core/css/StyleRule.cpp ('k') | Source/heap/HeapTest.cpp » ('j') | Source/wtf/Vector.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698