Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Issue 1992703006: [Android] Make snackbar more accesible (Closed)

Created:
4 years, 7 months ago by Ian Wen
Modified:
4 years, 7 months ago
Reviewers:
gone
CC:
chromium-reviews, dfalcantara+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Make snackbar more accesible This CL addes "more information available on bottom of the screen" to the accesibility announcement for snackbar. BUG=611568 Committed: https://crrev.com/91ffda9b71a0622ddb0e0ca3ccfd9fa9ab8433f1 Cr-Commit-Position: refs/heads/master@{#394844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/snackbar/SnackbarView.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Ian Wen
Hi Dan, PTAL at this small change. Thank you!
4 years, 7 months ago (2016-05-19 01:11:28 UTC) #2
gone
lgtm
4 years, 7 months ago (2016-05-19 17:30:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992703006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992703006/1
4 years, 7 months ago (2016-05-19 17:37:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 20:03:45 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 20:05:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91ffda9b71a0622ddb0e0ca3ccfd9fa9ab8433f1
Cr-Commit-Position: refs/heads/master@{#394844}

Powered by Google App Engine
This is Rietveld 408576698