Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: tools/testing/dart/test_options.dart

Issue 1992703005: Add test harness option for app snapshots with unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/test_options.dart
diff --git a/tools/testing/dart/test_options.dart b/tools/testing/dart/test_options.dart
index dfca7798212f847119f5577755c859abba3b0c43..c5c6e343dace51de67ceeb2fb16f83fbce2447e6 100644
--- a/tools/testing/dart/test_options.dart
+++ b/tools/testing/dart/test_options.dart
@@ -73,9 +73,9 @@ class TestOptionsParser {
(only valid with the following runtimes: none)
dart2app: Compile the Dart code into an app snapshot before running the test
- (only valid with the following runtimes: dart_product)''',
+ (only valid with the following runtimes: dart_app)''',
['-c', '--compiler'],
- ['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app'],
+ ['none', 'precompiler', 'dart2js', 'dart2analyzer', 'dart2app', 'dart2appjit'],
'none'),
// TODO(antonm): fix the option drt.
new _TestOptionSpecification(
@@ -86,7 +86,7 @@ class TestOptionsParser {
dart_precompiled: Run a precompiled snapshot on a variant of the standalone
dart vm lacking a JIT.
- dart_product: Run a full app snapshot in product mode.
+ dart_app: Run a full app snapshot, with or without cached unoptimized code.
d8: Run JavaScript from the command line using v8.
@@ -111,7 +111,7 @@ class TestOptionsParser {
[
'vm',
'dart_precompiled',
- 'dart_product',
+ 'dart_app',
'd8',
'jsshell',
'drt',
@@ -645,7 +645,10 @@ Note: currently only implemented for dart2js.''',
validRuntimes = const ['none'];
break;
case 'dart2app':
- validRuntimes = const ['dart_product'];
+ validRuntimes = const ['dart_app'];
+ break;
+ case 'dart2appjit':
+ validRuntimes = const ['dart_app'];
break;
case 'precompiler':
validRuntimes = const ['dart_precompiled'];

Powered by Google App Engine
This is Rietveld 408576698