Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1966)

Unified Diff: tools/testing/dart/runtime_configuration.dart

Issue 1992703005: Add test harness option for app snapshots with unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/testing/dart/runtime_configuration.dart
diff --git a/tools/testing/dart/runtime_configuration.dart b/tools/testing/dart/runtime_configuration.dart
index 822700f59d50fd22e3dee52a070b1722a46ac22b..8c10e10ea21291d52b3211240bdd578735eaac1e 100644
--- a/tools/testing/dart/runtime_configuration.dart
+++ b/tools/testing/dart/runtime_configuration.dart
@@ -50,8 +50,8 @@ class RuntimeConfiguration {
case 'vm':
return new StandaloneDartRuntimeConfiguration();
- case 'dart_product':
- return new DartProductRuntimeConfiguration();
+ case 'dart_app':
+ return new DartAppRuntimeConfiguration(useBlobs: useBlobs);
case 'dart_precompiled':
if (configuration['system'] == 'android') {
@@ -224,7 +224,10 @@ class StandaloneDartRuntimeConfiguration extends DartVmRuntimeConfiguration {
}
}
-class DartProductRuntimeConfiguration extends DartVmRuntimeConfiguration {
+class DartAppRuntimeConfiguration extends DartVmRuntimeConfiguration {
+ final bool useBlobs;
+ DartAppRuntimeConfiguration({bool useBlobs}) : useBlobs = useBlobs;
+
List<Command> computeRuntimeCommands(
TestSuite suite,
CommandBuilder commandBuilder,
@@ -234,11 +237,14 @@ class DartProductRuntimeConfiguration extends DartVmRuntimeConfiguration {
String script = artifact.filename;
String type = artifact.mimeType;
if (script != null && type != 'application/dart-snapshot') {
- throw "dart_product cannot run files of type '$type'.";
+ throw "dart_app cannot run files of type '$type'.";
}
var augmentedArgs = new List();
augmentedArgs.add("--run-app-snapshot=${artifact.filename}");
+ if (useBlobs) {
+ augmentedArgs.add("--use-blobs");
+ }
augmentedArgs.addAll(arguments);
return <Command>[

Powered by Google App Engine
This is Rietveld 408576698