Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1992703005: Add test harness option for app snapshots with unoptimized code. (Closed)

Created:
4 years, 7 months ago by rmacnak
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider, siva
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add test harness option for app snapshots with unoptimized code. ./tools/test.py -m all -c dart2appjit -r dart_app --use-blobs Rename 'dart_product' runtime to 'dart_app'. Rename Dart_PrecompiledJITSnapshotBlob to Dart_CreateAppJITSnapshot and add documentation. Remove out-of-date scripts in tools/precompilation. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/ef8baa8760a8699c4e155adec54572e9d6e16425

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+205 lines, -141 lines) Patch
M pkg/pkg.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/main.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 3 chunks +29 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/tests/vm/vm.status View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 10 chunks +24 lines, -8 lines 0 comments Download
M samples/samples.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/benchmark_smoke/benchmark_smoke.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-runtime.status View 8 chunks +13 lines, -11 lines 1 comment Download
M tests/corelib/corelib.status View 6 chunks +7 lines, -7 lines 0 comments Download
M tests/html/html.status View 1 chunk +1 line, -1 line 0 comments Download
M tests/isolate/isolate.status View 2 chunks +32 lines, -15 lines 0 comments Download
M tests/language/language.status View 7 chunks +14 lines, -14 lines 0 comments Download
M tests/lib/lib.status View 4 chunks +7 lines, -7 lines 0 comments Download
M tests/standalone/standalone.status View 8 chunks +15 lines, -13 lines 0 comments Download
D tools/precompilation/test_linux.sh View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/precompilation/test_linux_simarm.sh View 1 chunk +0 lines, -15 lines 0 comments Download
D tools/precompilation/test_macos.sh View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 2 chunks +34 lines, -0 lines 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 3 chunks +10 lines, -4 lines 0 comments Download
M tools/testing/dart/test_options.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
rmacnak
4 years, 7 months ago (2016-05-18 23:18:00 UTC) #2
rmacnak
4 years, 7 months ago (2016-05-24 02:52:27 UTC) #4
rmacnak
4 years, 7 months ago (2016-05-25 17:21:40 UTC) #5
Florian Schneider
lgtm
4 years, 7 months ago (2016-05-26 10:29:26 UTC) #6
rmacnak
Committed patchset #2 (id:20001) manually as ef8baa8760a8699c4e155adec54572e9d6e16425 (presubmit successful).
4 years, 7 months ago (2016-05-26 17:37:53 UTC) #8
siva
4 years, 6 months ago (2016-05-27 23:46:37 UTC) #9
Message was sent while issue was closed. 
lgtm

https://chromiumcodereview.appspot.com/1992703005/diff/20001/tests/co19/co19-...
File tests/co19/co19-runtime.status (right):

https://chromiumcodereview.appspot.com/1992703005/diff/20001/tests/co19/co19-...
tests/co19/co19-runtime.status:153: Language/Mixins/declaring_constructor_t01:
Pass
Not sure why we need this as it states the test should Pass isn't that the
default? what happens for other configurations?

Powered by Google App Engine
This is Rietveld 408576698