Added gyp build rules for brotli.

Added gyp build rules for brotli.

Brotli was put in without gyp rules, but it will be used on more than
just Android, so gyp rules needed to be added.

BUG=332521
Committed: https://crrev.com/783ff09104abc99c055b0e9e5dbce94c07452148
Cr-Commit-Position: refs/heads/master@{#395074}

[smaier, 2016-05-18 15:49:15]

smaier@chromium.org changed reviewers:
+ agrieve@chromium.org, bashi@chromium.org, brucedawson@chromium.org,
ksakamoto@chromium.org

[smaier, 2016-05-18 15:49:15]

ksakamoto@chromium.org: Please review changes in third_party/brotli

bashi@chromium.org: Please review changes in third_party/brotli

[brucedawson, 2016-05-18 21:21:32]

Building with gyp gives this error:

c:\src\chromium4\src\third_party\brotli\tools\bro.cc(290): warning C4530: C++
exception handler used, but unwind semantics are not enabled. Specify /EHsc

Searching *.gyp files for /EHsc shows that this is the canonical way to enable
/EHsc on Windows. I pasted this in to brotli.gyp and that is sufficient to make
it build on gyp.

        ['OS=="win"', {
          'msvs_settings': {
            'VCCLCompilerTool': {
              'AdditionalOptions': [ '/EHsc', ],
            },
          },
        }],

I can't tell if the .gypi file is correct - can you add a test or example of its
use to validate it?

https://codereview.chromium.org/1992703003/diff/1/third_party/brotli/bro.gypi
File third_party/brotli/bro.gypi (right):

https://codereview.chromium.org/1992703003/diff/1/third_party/brotli/bro.gypi...
third_party/brotli/bro.gypi:49: 
Please delete this blank line. "git cl patch" complains about it as a whitespace
error:

<stdin>:69: new blank line at EOF.
+
warning: 1 line adds whitespace errors.

[smaier, 2016-05-19 15:50:22]

On 2016/05/18 21:21:32, brucedawson wrote:
> Building with gyp gives this error:
> 
> c:\src\chromium4\src\third_party\brotli\tools\bro.cc(290): warning C4530: C++
> exception handler used, but unwind semantics are not enabled. Specify /EHsc
> 
> Searching *.gyp files for /EHsc shows that this is the canonical way to enable
> /EHsc on Windows. I pasted this in to brotli.gyp and that is sufficient to
make
> it build on gyp.
> 
>         ['OS=="win"', {
>           'msvs_settings': {
>             'VCCLCompilerTool': {
>               'AdditionalOptions': [ '/EHsc', ],
>             },
>           },
>         }],
> 
> I can't tell if the .gypi file is correct - can you add a test or example of
its
> use to validate it?
> 
> https://codereview.chromium.org/1992703003/diff/1/third_party/brotli/bro.gypi
> File third_party/brotli/bro.gypi (right):
> 
>
https://codereview.chromium.org/1992703003/diff/1/third_party/brotli/bro.gypi...
> third_party/brotli/bro.gypi:49: 
> Please delete this blank line. "git cl patch" complains about it as a
whitespace
> error:
> 
> <stdin>:69: new blank line at EOF.
> +
> warning: 1 line adds whitespace errors.

There is an example in this review: https://codereview.chromium.org/1951363002/

Thanks for all the Windows help!

[brucedawson, 2016-05-19 18:41:46]

brotli.gyp lgtm with indentation nit.

https://codereview.chromium.org/1992703003/diff/60001/third_party/brotli/brot...
File third_party/brotli/brotli.gyp (right):

https://codereview.chromium.org/1992703003/diff/60001/third_party/brotli/brot...
third_party/brotli/brotli.gyp:93: 'msvs_settings': {
Indentation should be fixed here.

[bashi, 2016-05-19 22:59:48]

rubber-stamp lgtm

[smaier, 2016-05-20 14:18:17]

The CQ bit was checked by smaier@chromium.org

[smaier, 2016-05-20 14:18:18]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org,
brucedawson@chromium.org
Link to the patchset: https://codereview.chromium.org/1992703003/#ps80001
(title: "Changed double quotes and tabs")

[commit-bot: I haz the power, 2016-05-20 14:18:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992703003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992703003/80001

[commit-bot: I haz the power, 2016-05-20 15:01:09]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-05-20 15:02:05]

Description was changed from

==========
Added gyp build rules for brotli.

Brotli was put in without gyp rules, but it will be used on more than
just Android, so gyp rules needed to be added.

BUG=332521
==========

to

==========
Added gyp build rules for brotli.

Brotli was put in without gyp rules, but it will be used on more than
just Android, so gyp rules needed to be added.

BUG=332521

Committed: https://crrev.com/783ff09104abc99c055b0e9e5dbce94c07452148
Cr-Commit-Position: refs/heads/master@{#395074}
==========

[commit-bot: I haz the power, 2016-05-20 15:02:07]

Patchset 5 (id:??) landed as
https://crrev.com/783ff09104abc99c055b0e9e5dbce94c07452148
Cr-Commit-Position: refs/heads/master@{#395074}