Brotli compression used on about credits html file.

Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The presubmit script had to be edited to allow the "#include ../" that was used in brotli's "tools" folder.

BUG=332521
Committed: https://crrev.com/25a7bd32c100d554855af779a1a2b9dcc70a3b97
Cr-Commit-Position: refs/heads/master@{#395920}

[smaier, 2016-05-06 16:05:30]

Description was changed from

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B (~1.3MB).

BUG=332521
==========

to

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B (~1.3MB).

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

[smaier, 2016-05-06 16:05:54]

Description was changed from

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B (~1.3MB).

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

to

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

[smaier, 2016-05-06 17:07:57]

On 2016/05/06 16:05:54, smaier wrote:
> Description was changed from
> 
> ==========
> Brotli compression used on about credits html file.
> 
> resources.pak shrunk by 1285356B (~1.3MB).
> 
> To make use of brotli's compression, more of brotli's repo was added. The
> presubmit script had to be edited to allow the "#include ../" that was used in
> brotli's "tools" folder.
> 
> BUG=332521
> ==========
> 
> to
> 
> ==========
> Brotli compression used on about credits html file.
> 
> resources.pak shrunk by 1285356B.
> 
> To make use of brotli's compression, more of brotli's repo was added. The
> presubmit script had to be edited to allow the "#include ../" that was used in
> brotli's "tools" folder.
> 
> BUG=332521
> ==========

Note: presubmit is broken for this change, but fixed by
https://codereview.chromium.org/1954943003/

[smaier, 2016-05-06 17:14:37]

smaier@chromium.org changed reviewers:
+ bashi@chromium.org, blundell@chromium.org, ksakamoto@chromium.org,
phajdan.jr@chromium.org, sky@chromium.org

[smaier, 2016-05-06 17:14:38]

blundell@chromium.org: Please review changes in components/

phajdan.jr@chromium.org: Please review changes in PRESUBMIT.py

ksakamoto@chromium.org, bashi@chromium.org: Please review changes in brotli/

sky@chromium.org: Please review changes in chrome/browser/ui

[smaier, 2016-05-06 17:14:57]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-06 17:15:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/40001

[commit-bot: I haz the power, 2016-05-06 17:21:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 17:21:36]

Dry run: Try jobs failed on following builders:
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[smaier, 2016-05-06 19:02:14]

smaier@chromium.org changed reviewers:
- bashi@chromium.org, ksakamoto@chromium.org

[smaier, 2016-05-06 19:03:09]

smaier@chromium.org changed reviewers:
- phajdan.jr@chromium.org

[sky, 2016-05-06 21:37:14]

12MB! WOW! LGTM

[blundell, 2016-05-09 07:42:48]

//components LGTM

[smaier, 2016-05-20 15:27:36]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 15:27:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/80001

[commit-bot: I haz the power, 2016-05-20 15:37:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 15:37:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[smaier, 2016-05-20 20:02:01]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 20:02:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/120001

[commit-bot: I haz the power, 2016-05-20 20:14:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 20:15:00]

Dry run: Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[smaier, 2016-05-20 20:50:52]

The CQ bit was checked by smaier@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-20 20:51:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/160001

[commit-bot: I haz the power, 2016-05-20 21:37:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 21:37:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2016-05-25 02:46:37]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 02:47:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/260001

[commit-bot: I haz the power, 2016-05-25 04:22:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 04:22:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[agrieve, 2016-05-25 13:18:02]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 13:18:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/260001

[commit-bot: I haz the power, 2016-05-25 13:49:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 13:50:00]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 13:50:08]

Dry run: None

[smaier, 2016-05-25 17:13:26]

The CQ bit was checked by smaier@chromium.org

[smaier, 2016-05-25 17:13:26]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
blundell@chromium.org
Link to the patchset: https://codereview.chromium.org/1951363002/#ps260001
(title: "Guarded Windows include")

[commit-bot: I haz the power, 2016-05-25 17:13:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1951363002/260001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1951363002/260001

[commit-bot: I haz the power, 2016-05-25 17:21:07]

Description was changed from

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

to

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

[commit-bot: I haz the power, 2016-05-25 17:21:08]

Committed patchset #17 (id:260001)

[commit-bot: I haz the power, 2016-05-25 17:22:10]

Description was changed from

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521
==========

to

==========
Brotli compression used on about credits html file.

resources.pak shrunk by 1285356B.

To make use of brotli's compression, more of brotli's repo was added. The
presubmit script had to be edited to allow the "#include ../" that was used in
brotli's "tools" folder.

BUG=332521

Committed: https://crrev.com/25a7bd32c100d554855af779a1a2b9dcc70a3b97
Cr-Commit-Position: refs/heads/master@{#395920}
==========

[commit-bot: I haz the power, 2016-05-25 17:22:11]

Patchset 17 (id:??) landed as
https://crrev.com/25a7bd32c100d554855af779a1a2b9dcc70a3b97
Cr-Commit-Position: refs/heads/master@{#395920}

[agrieve, 2016-05-25 18:04:38]

On 2016/05/06 21:37:14, sky wrote:
> 12MB! WOW! LGTM

Note: it's 1.2MB. But still... wow!

[sky, 2016-05-25 19:37:18]

On 2016/05/25 18:04:38, agrieve wrote:
> On 2016/05/06 21:37:14, sky wrote:
> > 12MB! WOW! LGTM
> 
> Note: it's 1.2MB. But still... wow!

My vision is going. I read 1285356B as 12853568. None-the-less 1.2MB is still
AWESOME!

[smaier, 2016-05-26 14:30:43]

A revert of this CL (patchset #17 id:260001) has been created in
https://codereview.chromium.org/2013493006/ by smaier@chromium.org.

The reason for reverting is: Broke downstream x64 official builder.