Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1534)

Issue 19927002: Fix invalid SMI test in x64 ToNumberStub::Generate(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix invalid SMI test in x64 ToNumberStub::Generate(). TBR=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M src/x64/code-stubs-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Benedikt Meurer
Committed patchset #1 manually as r15788 (presubmit successful).
7 years, 5 months ago (2013-07-22 06:13:50 UTC) #1
Sven Panne
7 years, 5 months ago (2013-07-22 06:44:58 UTC) #2
Message was sent while issue was closed.
LGTM. For bonus points, prepare a CL adding AssertSmi to MacroAssembler::SmiTest
to avoid similar problems in the future. :-)

Powered by Google App Engine
This is Rietveld 408576698