Issue 19927002: Fix invalid SMI test in x64 ToNumberStub::Generate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 19927002: Fix invalid SMI test in x64 ToNumberStub::Generate(). (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	src/x64/code-stubs-x64.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Benedikt Meurer

Committed patchset #1 manually as r15788 (presubmit successful).

7 years, 5 months ago (2013-07-22 06:13:50 UTC) #1

Sven Panne

7 years, 5 months ago (2013-07-22 06:44:58 UTC) #2

Message was sent while issue was closed.

LGTM. For bonus points, prepare a CL adding AssertSmi to MacroAssembler::SmiTest
to avoid similar problems in the future. :-)