src/x64/code-stubs-x64.cc - Issue 19927002: Fix invalid SMI test in x64 ToNumberStub::Generate().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/code-stubs-x64.cc

Issue 19927002: Fix invalid SMI test in x64 ToNumberStub::Generate(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/code-stubs-x64.cc

diff --git a/src/x64/code-stubs-x64.cc b/src/x64/code-stubs-x64.cc

index 652a4db7a6b58d9a4ed08fceb900c6af14bb6611..e090437d559024ec394575560896dae5c3c1d755 100644

--- a/src/x64/code-stubs-x64.cc

+++ b/src/x64/code-stubs-x64.cc

@@ -299,8 +299,7 @@ void HydrogenCodeStub::GenerateLightweightMiss(MacroAssembler* masm) {

void ToNumberStub::Generate(MacroAssembler* masm) {

// The ToNumber stub takes one argument in rax.

Label check_heap_number, call_builtin;

- __ SmiTest(rax);

- __ j(not_zero, &check_heap_number, Label::kNear);

+ __ JumpIfNotSmi(rax, &check_heap_number, Label::kNear);

__ Ret();

__ bind(&check_heap_number);

« no previous file with comments | « no previous file | no next file » | no next file with comments »