Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1992593002:
Disable BookmarkBarControllerTest.LastBookmarkResizeBehavior (Closed)
DescriptionBookmarkBarControllerTest.LastBookmarkResizeBehavior
TBR=avi@chromium.org,cpu@chromium.org
BUG=612640
Committed: https://crrev.com/a9ec27d0c6fc777589035e7acd4942f7be55b0c5
Cr-Commit-Position: refs/heads/master@{#394314}
Patch Set 1 #Patch Set 2 : Rebased #Messages
Total messages: 19 (9 generated)
qyearsley@chromium.org changed reviewers: + avi@chromium.org, cpu@chromium.org, shrike@chromium.org
As noted in http://crbug.com/612640: This test started failing after https://codereview.chromium.org/1941583002/; I tried to revert with https://codereview.chromium.org/1986963004/, but that caused build failures.
LGTM (though I am not an owner of this file)
Description was changed from ========== BookmarkBarControllerTest.LastBookmarkResizeBehavior BUG=612640 ========== to ========== BookmarkBarControllerTest.LastBookmarkResizeBehavior TBR=avi@chromium.org,cpu@chromium.org BUG=612640 ==========
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992593002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992593002/20001
Will wait until https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests cycles one time to see if this test fails on the waterfall before committing
On 2016/05/18 at 00:34:50, qyearsley wrote: > Will wait until https://build.chromium.org/p/chromium.mac/builders/Mac10.11%20Tests cycles one time to see if this test fails on the waterfall before committing This test failed again in the latest build (#1622); will now disable.
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from shrike@chromium.org Link to the patchset: https://codereview.chromium.org/1992593002/#ps20001 (title: "Rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992593002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992593002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== BookmarkBarControllerTest.LastBookmarkResizeBehavior TBR=avi@chromium.org,cpu@chromium.org BUG=612640 ========== to ========== BookmarkBarControllerTest.LastBookmarkResizeBehavior TBR=avi@chromium.org,cpu@chromium.org BUG=612640 Committed: https://crrev.com/a9ec27d0c6fc777589035e7acd4942f7be55b0c5 Cr-Commit-Position: refs/heads/master@{#394314} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/a9ec27d0c6fc777589035e7acd4942f7be55b0c5 Cr-Commit-Position: refs/heads/master@{#394314} |
