Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Side by Side Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm

Issue 1992593002: Disable BookmarkBarControllerTest.LastBookmarkResizeBehavior (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h> 5 #import <Cocoa/Cocoa.h>
6 #include <stddef.h> 6 #include <stddef.h>
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/mac/mac_util.h" 10 #include "base/mac/mac_util.h"
(...skipping 1558 matching lines...) Expand 10 before | Expand all | Expand 10 after
1569 EXPECT_FALSE([view isHidden]); 1569 EXPECT_FALSE([view isHidden]);
1570 [bar_ shrinkOrHideView:view forMaxX:31.0]; 1570 [bar_ shrinkOrHideView:view forMaxX:31.0];
1571 EXPECT_EQ(31.0, NSWidth([view frame])); 1571 EXPECT_EQ(31.0, NSWidth([view frame]));
1572 EXPECT_FALSE([view isHidden]); 1572 EXPECT_FALSE([view isHidden]);
1573 [bar_ shrinkOrHideView:view forMaxX:29.0]; 1573 [bar_ shrinkOrHideView:view forMaxX:29.0];
1574 EXPECT_TRUE([view isHidden]); 1574 EXPECT_TRUE([view isHidden]);
1575 } 1575 }
1576 1576
1577 // Simiulate browser window width change and ensure that the bookmark buttons 1577 // Simiulate browser window width change and ensure that the bookmark buttons
1578 // that should be visible are visible. 1578 // that should be visible are visible.
1579 TEST_F(BookmarkBarControllerTest, LastBookmarkResizeBehavior) { 1579 // Appears to fail on Mac 10.11 bot on the waterfall; http://crbug.com/612640.
1580 TEST_F(BookmarkBarControllerTest, DISABLED_LastBookmarkResizeBehavior) {
1580 // Hide the apps shortcut. 1581 // Hide the apps shortcut.
1581 profile()->GetPrefs()->SetBoolean( 1582 profile()->GetPrefs()->SetBoolean(
1582 bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false); 1583 bookmarks::prefs::kShowAppsShortcutInBookmarkBar, false);
1583 ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]); 1584 ASSERT_TRUE([bar_ appsPageShortcutButtonIsHidden]);
1584 1585
1585 // Add three buttons to the bookmark bar. 1586 // Add three buttons to the bookmark bar.
1586 BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile()); 1587 BookmarkModel* model = BookmarkModelFactory::GetForProfile(profile());
1587 const BookmarkNode* root = model->bookmark_bar_node(); 1588 const BookmarkNode* root = model->bookmark_bar_node();
1588 const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b "); 1589 const std::string model_string("1b 2f:[ 2f1b 2f2b ] 3b ");
1589 bookmarks::test::AddNodesFromModelString(model, root, model_string); 1590 bookmarks::test::AddNodesFromModelString(model, root, model_string);
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
2200 "2f3b ] 4b "); 2201 "2f3b ] 4b ");
2201 actual = bookmarks::test::ModelStringFromNode(root); 2202 actual = bookmarks::test::ModelStringFromNode(root);
2202 EXPECT_EQ(expected, actual); 2203 EXPECT_EQ(expected, actual);
2203 2204
2204 // Verify that the other bookmark folder can't be deleted. 2205 // Verify that the other bookmark folder can't be deleted.
2205 BookmarkButton *otherButton = [bar_ otherBookmarksButton]; 2206 BookmarkButton *otherButton = [bar_ otherBookmarksButton];
2206 EXPECT_FALSE([bar_ canDragBookmarkButtonToTrash:otherButton]); 2207 EXPECT_FALSE([bar_ canDragBookmarkButtonToTrash:otherButton]);
2207 } 2208 }
2208 2209
2209 } // namespace 2210 } // namespace
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698