[DevTools] Pass bindRemoteObject function to Custom Formatter directly

[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af
Cr-Commit-Position: refs/heads/master@{#394562}

[kozy, 2016-05-17 21:11:28]

Andrey and Dmitry, please take a look!

[dgozman, 2016-05-17 22:05:38]

lgtm

https://codereview.chromium.org/1992493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1992493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:818: var
bindRemoteObjectFunctionId = injectedScript._bind(wrap, objectGroupName);
Let's store this on InjectedScript.

[kozy, 2016-05-17 22:35:26]

Pavel, please take a look! I need owner lgtm for V8WindowCustom.

https://codereview.chromium.org/1992493002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/1992493002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:818: var
bindRemoteObjectFunctionId = injectedScript._bind(wrap, objectGroupName);
On 2016/05/17 22:05:38, dgozman wrote:
> Let's store this on InjectedScript.

We can't do it.
I need to bind it to objectGroupName of current object.

[kozy, 2016-05-17 22:35:52]

Description was changed from

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org
==========

to

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org
==========

[kozy, 2016-05-17 22:35:52]

kozyatinskiy@chromium.org changed reviewers:
+ pfeldman@chromium.org

[kozy, 2016-05-17 22:36:14]

Pavel, please take a look. I need owner lgtm for V8WindowCustom.

[pfeldman, 2016-05-18 18:43:27]

lgtm

[kozy, 2016-05-18 20:21:13]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-05-18 20:21:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992493002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992493002/20001

[commit-bot: I haz the power, 2016-05-18 21:58:03]

Description was changed from

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org
==========

[commit-bot: I haz the power, 2016-05-18 21:58:04]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-18 22:00:51]

Description was changed from

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org
==========

to

==========
[DevTools] Pass bindRemoteObject function to Custom Formatter directly

BUG=595206
R=dgozman@chromium.org,lushnikov@chromium.org,pfeldman@chromium.org

Committed: https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af
Cr-Commit-Position: refs/heads/master@{#394562}
==========

[commit-bot: I haz the power, 2016-05-18 22:00:53]

Patchset 2 (id:??) landed as
https://crrev.com/2c30f24ecc1c52d3dcadf4c6025b6f8f14f426af
Cr-Commit-Position: refs/heads/master@{#394562}