third_party/WebKit/Source/devtools/protocol.json - Issue 1992493002: [DevTools] Pass bindRemoteObject function to Custom Formatter directly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/protocol.json

Issue 1992493002: [DevTools] Pass bindRemoteObject function to Custom Formatter directly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/components/CustomPreviewSection.js ('k') | third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h » ('j') | third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/protocol.json

diff --git a/third_party/WebKit/Source/devtools/protocol.json b/third_party/WebKit/Source/devtools/protocol.json

index f2d5a6bcef3ef9d33f7c1d540f54d6e74e070cdc..dd214bd89e38bf10be5e83ecad750b1e0e1a6bd8 100644

--- a/third_party/WebKit/Source/devtools/protocol.json

+++ b/third_party/WebKit/Source/devtools/protocol.json

@@ -792,14 +792,16 @@

{ "name": "customPreview", "$ref": "CustomPreview", "optional": true, "hidden": true}

]

- { "id": "CustomPreview",

+ {

+ "id": "CustomPreview",

"type": "object",

"hidden": true,

"properties": [

{ "name": "header", "type": "string"},

{ "name": "hasBody", "type": "boolean"},

- {"name": "formatterObjectId", "$ref": "RemoteObjectId"},

- {"name": "configObjectId", "$ref": "RemoteObjectId", "optional": true}

+ { "name": "formatterObjectId", "$ref": "RemoteObjectId"},

+ { "name": "bindRemoteObjectFunctionId", "$ref": "RemoteObjectId" },

+ { "name": "configObjectId", "$ref": "RemoteObjectId", "optional": true }

]

{