Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2396)

Unified Diff: content/renderer/render_frame_impl.h

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.h
diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h
index 3ddbf72d8c089821d021833c62ee879a7294abe3..9f2c58417ade23d3693ec2f5df9de74c2bb03dad 100644
--- a/content/renderer/render_frame_impl.h
+++ b/content/renderer/render_frame_impl.h
@@ -364,7 +364,7 @@ class CONTENT_EXPORT RenderFrameImpl
// NULL.
MediaStreamDispatcher* GetMediaStreamDispatcher();
-#if defined(OS_MACOSX) || defined(OS_ANDROID)
+#if defined(USE_EXTERNAL_POPUP_MENU)
void DidHideExternalPopupMenu();
#endif
@@ -819,6 +819,9 @@ class CONTENT_EXPORT RenderFrameImpl
#if defined(OS_ANDROID)
void OnActivateNearestFindResult(int request_id, float x, float y);
void OnFindMatchRects(int current_version);
+#endif
+
+#if defined(USE_EXTERNAL_POPUP_MENU) && !defined(OS_MACOSX)
Wez 2016/05/27 02:24:51 nit: This might read more clearly as a nested #if,
haibinlu 2016/05/28 01:37:59 Done.
void OnSelectPopupMenuItems(bool canceled,
const std::vector<int>& selected_indices);
#elif defined(OS_MACOSX)
@@ -1214,7 +1217,7 @@ class CONTENT_EXPORT RenderFrameImpl
// stack that interferes with swapping out.
bool suppress_further_dialogs_;
-#if defined(OS_MACOSX) || defined(OS_ANDROID)
+#if defined(USE_EXTERNAL_POPUP_MENU)
// The external popup for the currently showing select popup.
std::unique_ptr<ExternalPopupMenu> external_popup_menu_;
#endif

Powered by Google App Engine
This is Rietveld 408576698