content/renderer/external_popup_menu.cc - Issue 1992393002: Enable external popup menu in Blimp, part 1/2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/external_popup_menu.cc

Issue 1992393002: Enable external popup menu in Blimp, part 1/2. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/external_popup_menu.cc

diff --git a/content/renderer/external_popup_menu.cc b/content/renderer/external_popup_menu.cc

index 7bb01a1d32036ba35ac23e33a8128710868106ac..b5141989c5c06a1f03651c48b4442057c56da1f9 100644

--- a/content/renderer/external_popup_menu.cc

+++ b/content/renderer/external_popup_menu.cc

@@ -74,7 +74,7 @@ void ExternalPopupMenu::DidSelectItem(int index) {

}

#endif

-#if defined(OS_ANDROID)

+#if defined(USE_EXTERNAL_POPUP_MENU) && !defined(OS_MACOSX)

void ExternalPopupMenu::DidSelectItems(bool canceled,

const std::vector<int>& indices) {

if (!popup_menu_client_)