DevTools: add eslint as presubmit hook

DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman

Committed: https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2
Cr-Commit-Position: refs/heads/master@{#395203}

[lushnikov, 2016-05-19 23:12:13]

Description was changed from

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

to

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

[lushnikov, 2016-05-19 23:12:13]

lushnikov@chromium.org changed reviewers:
- dgozman@chromium.org, paulirish@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-05-20 19:36:11]

Description was changed from

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

to

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

[lushnikov, 2016-05-20 19:36:11]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, paulirish@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-05-20 19:36:20]

ptal

[paulirish, 2016-05-20 20:26:22]

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:53: if "error" in out or
"warning" in out:
You should use the exit code instead. 

Generally, it's expected to not have warnings break the presubmit (but using
exit code will address this)

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/.eslintrc.js (left):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/.eslintrc.js:31: "yoda": [2,
"never"],
I believe we're good with this:

"yoda": [2, "never", { 
    "exceptRange": true 
}],

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/lint_javascript.py (right):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/lint_javascript.py:104: return
eslint_errors_found
Thanks. Not sure why it was missing.

[lushnikov, 2016-05-20 20:54:56]

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:53: if "error" in out or
"warning" in out:
On 2016/05/20 20:26:22, paulirish wrote:
> You should use the exit code instead. 
> 
> Generally, it's expected to not have warnings break the presubmit (but using
> exit code will address this)

Done.

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/.eslintrc.js (left):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/.eslintrc.js:31: "yoda": [2,
"never"],
Tried that, didn't work due to the CallStackSidebarPane.js:336

 while (0 <= index && index < this.callFrames.length) {

Apparently, this is not considered to be a range due to variable on the right
side

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/scripts/lint_javascript.py (right):

https://codereview.chromium.org/1992383002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/scripts/lint_javascript.py:104: return
eslint_errors_found
On 2016/05/20 20:26:22, paulirish wrote:
> Thanks. Not sure why it was missing.

Acknowledged.

[dgozman, 2016-05-20 21:12:59]

stampy stamp lgtm

https://codereview.chromium.org/1992383002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/1992383002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:45: affected_front_end_files =
[input_api.os_path.join("front_end",
file_name.split(devtools_front_end).pop()[1:]) for file_name in
affected_front_end_files]
input_api.os_path.relpath

[lushnikov, 2016-05-20 21:49:26]

https://codereview.chromium.org/1992383002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/PRESUBMIT.py (right):

https://codereview.chromium.org/1992383002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/PRESUBMIT.py:45: affected_front_end_files =
[input_api.os_path.join("front_end",
file_name.split(devtools_front_end).pop()[1:]) for file_name in
affected_front_end_files]
On 2016/05/20 21:12:59, dgozman wrote:
> input_api.os_path.relpath

Done.

[lushnikov, 2016-05-20 21:49:32]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-05-20 21:49:32]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1992383002/#ps100001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-20 21:49:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1992383002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1992383002/100001

[commit-bot: I haz the power, 2016-05-20 23:37:35]

Description was changed from

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

to

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-05-20 23:37:36]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-05-20 23:39:18]

Description was changed from

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman
==========

to

==========
DevTools: add eslint as presubmit hook

The patch sets up eslint as a presubmit hooks for the DevTools frontend.

The hooks validates only modified javascript files
and works blazingly fast.

BUG=605878
R=paulirish, dgozman, pfeldman

Committed: https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2
Cr-Commit-Position: refs/heads/master@{#395203}
==========

[commit-bot: I haz the power, 2016-05-20 23:39:19]

Patchset 6 (id:??) landed as
https://crrev.com/ddf9471bf9b0f1b05b5eabd790dda8836a4184d2
Cr-Commit-Position: refs/heads/master@{#395203}

[lushnikov, 2016-05-23 19:14:43]

for the record: the eslint should be installed separately.