third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js - Issue 1992383002: DevTools: add eslint as presubmit hook

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

Issue 1992383002: DevTools: add eslint as presubmit hook (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/.eslintrc.js ('k') | third_party/WebKit/Source/devtools/front_end/formatter_worker.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js b/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

index a944b761f53b050307c778e32f60715b53792947..cdf5ed07ee9f0d9948c87ce60c489eed5f2a9a57 100644

--- a/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

+++ b/third_party/WebKit/Source/devtools/front_end/emulation/SensorsView.js

@@ -253,7 +253,7 @@ WebInspector.SensorsView.prototype = {

function roundAngle(angle)

{

- return Math.round(angle*10000)/10000;

+ return Math.round(angle * 10000) / 10000;

}

if (modificationSource != WebInspector.SensorsView.DeviceOrientationModificationSource.UserInput) {

@@ -341,7 +341,7 @@ WebInspector.SensorsView.prototype = {

var axis, angle;

if (event.shiftKey) {

axis = new WebInspector.Geometry.Vector(0, 0, -1);

- angle = (this._mouseDownVector.x - mouseMoveVector.x)*WebInspector.SensorsView.ShiftDragOrientationSpeed;

+ angle = (this._mouseDownVector.x - mouseMoveVector.x) * WebInspector.SensorsView.ShiftDragOrientationSpeed;

} else {

axis = WebInspector.Geometry.crossProduct(this._mouseDownVector, mouseMoveVector);

angle = WebInspector.Geometry.calculateAngle(this._mouseDownVector, mouseMoveVector);