Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 1992243002: Revert of Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup (Closed)

Created:
4 years, 7 months ago by katrielc
Modified:
4 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup (patchset #4 id:60001 of https://codereview.chromium.org/1982643002/ ) Reason for revert: The signature change for LogToDebug broke JNI on Android. Original issue's description: > Fix backwards WebRTC-in-Chromium override, and expose a way for WebRTC code to initialise the Chromium logging system. > > BUG=561667 > > Committed: https://crrev.com/85d72ea76ae71e4b9d71d990e67c9d6b3cc1d145 > Cr-Commit-Position: refs/heads/master@{#394384} TBR=grunell@chromium.org,tommi@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=561667 Committed: https://crrev.com/422e802b3862f7a1c1827fe735eb67a8329b6ca5 Cr-Commit-Position: refs/heads/master@{#394765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -35 lines) Patch
M third_party/webrtc_overrides/webrtc/base/diagnostic_logging.h View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/webrtc_overrides/webrtc/base/logging.h View 1 chunk +0 lines, -9 lines 0 comments Download
M third_party/webrtc_overrides/webrtc/base/logging.cc View 4 chunks +2 lines, -18 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
katrielc
Created Revert of Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup
4 years, 7 months ago (2016-05-19 13:12:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992243002/1
4 years, 7 months ago (2016-05-19 13:12:15 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-19 13:12:16 UTC) #4
phoglund_chromium
lgtm lgtm
4 years, 7 months ago (2016-05-19 13:15:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992243002/1
4 years, 7 months ago (2016-05-19 13:16:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 14:34:09 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 14:35:57 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/422e802b3862f7a1c1827fe735eb67a8329b6ca5
Cr-Commit-Position: refs/heads/master@{#394765}

Powered by Google App Engine
This is Rietveld 408576698