Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/webrtc_overrides/webrtc/base/logging.cc

Issue 1992243002: Revert of Fix backwards WebRTC-in-Chromium override and expose Chromium logging setup (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/webrtc_overrides/webrtc/base/logging.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/webrtc_overrides/webrtc/base/logging.cc
diff --git a/third_party/webrtc_overrides/webrtc/base/logging.cc b/third_party/webrtc_overrides/webrtc/base/logging.cc
index 797dc339b384780671593fcbdb0df18e63bd1fd0..db888c1a4ad2c43c0cb526d3859dbab90ee43a01 100644
--- a/third_party/webrtc_overrides/webrtc/base/logging.cc
+++ b/third_party/webrtc_overrides/webrtc/base/logging.cc
@@ -13,10 +13,8 @@
#include <algorithm>
#include <iomanip>
-#include <string>
#include "base/atomicops.h"
-#include "base/command_line.h"
#include "base/logging.h"
#include "base/strings/string_util.h"
#include "base/threading/platform_thread.h"
@@ -51,16 +49,6 @@
base::subtle::Atomic32 g_init_logging_delegate_thread_id = 0;
#endif
-void InitChromiumLoggingAndCommandLine() {
- // 0 means no arguments, so the null argv is never touched
- base::CommandLine::Init(0, nullptr);
-
- // Chromium checks for the presence of --v when deciding log level.
- // Note that the *value* of --v doesn't matter for this check.
- base::CommandLine::ForCurrentProcess()->AppendSwitchASCII("v", "");
- logging::InitLogging(logging::LoggingSettings());
-}
-
/////////////////////////////////////////////////////////////////////////////
// Constant Labels
/////////////////////////////////////////////////////////////////////////////
@@ -92,10 +80,6 @@
inline int WebRtcSevToChromeSev(LoggingSeverity sev) {
switch (sev) {
- case LS_NONE:
- // Used to set the log level for "no logging", so must be less
- // than LOG_ERROR.
- return ::logging::LOG_FATAL;
case LS_ERROR:
return ::logging::LOG_ERROR;
case LS_WARNING:
@@ -217,8 +201,8 @@
}
// static
-void LogMessage::LogToDebug(LoggingSeverity min_sev) {
- logging::SetMinLogLevel(WebRtcSevToChromeSev(min_sev));
+void LogMessage::LogToDebug(int min_sev) {
+ logging::SetMinLogLevel(min_sev);
}
// Note: this function is a copy from the overriden libjingle implementation.
« no previous file with comments | « third_party/webrtc_overrides/webrtc/base/logging.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698