Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1992163002: Revert of Adding ia32 simd assembler changes. (Closed)

Created:
4 years, 7 months ago by Michael Achenbach
Modified:
4 years, 7 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Adding ia32 simd assembler changes. (patchset #2 id:20001 of https://codereview.chromium.org/1991713002/ ) Reason for revert: Crashes on win32 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug/builds/2305/steps/Check/logs/stdio Also, would be nice if the test output could be a bit shorter and only print what's necessary to trace a failure. Or split things into more smaller tests. Like that, these logs must be processed, json-encoded/decoded and sent around through the infrastructure. Some chars in the output make the json encoder unhappy, therefore the infrastructure can't nicely display the failures. Original issue's description: > Adding ia32 simd assembler support. > > Based on assembler changes from this patch: > https://codereview.chromium.org/90643003/ > > BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 > R=titzer@chromium.org > LOG=N > > Committed: https://crrev.com/fbf58a5af1d07a7fbb3763aa15f8ba26e2ce7d11 > Cr-Commit-Position: refs/heads/master@{#36349} TBR=bbudge@chromium.org,titzer@chromium.org,gdeepti@chromium.org,aseemgarg@chromium.org,bradnelson@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://bugs.chromium.org/p/v8/issues/detail?id=4124 Committed: https://crrev.com/479de28c3aea08643a371097c480eb73e81c6930 Cr-Commit-Position: refs/heads/master@{#36353}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -378 lines) Patch
M src/ia32/assembler-ia32.h View 5 chunks +1 line, -49 lines 0 comments Download
M src/ia32/assembler-ia32.cc View 2 chunks +0 lines, -193 lines 0 comments Download
M src/ia32/disasm-ia32.cc View 7 chunks +18 lines, -82 lines 0 comments Download
M test/cctest/test-disasm-ia32.cc View 3 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Adding ia32 simd assembler changes.
4 years, 7 months ago (2016-05-19 08:57:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1992163002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1992163002/1
4 years, 7 months ago (2016-05-19 08:57:54 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 08:58:09 UTC) #4
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 08:58:28 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/479de28c3aea08643a371097c480eb73e81c6930
Cr-Commit-Position: refs/heads/master@{#36353}

Powered by Google App Engine
This is Rietveld 408576698