Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1991893002: Remove debug code from the autosign-in first run on Mac. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
dvadym
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove debug code from the autosign-in first run on Mac. https://codereview.chromium.org/1961023002 introduced it. However, I was just experimenting with the approach. It didn't work well. Therefore, the block was landed by mistake. BUG=609810 Committed: https://crrev.com/4d141f6fff8b47d89818867f6f4fd6bbda174daf Cr-Commit-Position: refs/heads/master@{#394717}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
vasilii
Hi Vadym, please review the CL.
4 years, 7 months ago (2016-05-18 17:17:46 UTC) #2
dvadym
On 2016/05/18 17:17:46, vasilii wrote: > Hi Vadym, > > please review the CL. LGTM
4 years, 7 months ago (2016-05-19 08:32:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991893002/1
4 years, 7 months ago (2016-05-19 08:34:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-19 08:38:26 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-19 08:39:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4d141f6fff8b47d89818867f6f4fd6bbda174daf
Cr-Commit-Position: refs/heads/master@{#394717}

Powered by Google App Engine
This is Rietveld 408576698