Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1961023002: Close the account chooser and auto sign-in opt in with ESC on Mac. (Closed)

Created:
4 years, 7 months ago by vasilii
Modified:
4 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Close the account chooser and auto sign-in opt in with ESC on Mac. BUG=609810 Committed: https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07 Cr-Commit-Position: refs/heads/master@{#392298}

Patch Set 1 #

Total comments: 6

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/account_chooser_view_controller_unittest.mm View 3 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm View 1 7 chunks +49 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller_unittest.mm View 3 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vasilii
Hi Vaclav, please review.
4 years, 7 months ago (2016-05-09 09:53:28 UTC) #2
vabr (Chromium)
LGTM with a question and some comments. https://codereview.chromium.org/1961023002/diff/1/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm File chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm (right): https://codereview.chromium.org/1961023002/diff/1/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm#newcode39 chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm:39: @property (nonatomic, ...
4 years, 7 months ago (2016-05-09 11:16:17 UTC) #3
vasilii
https://codereview.chromium.org/1961023002/diff/1/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm File chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm (right): https://codereview.chromium.org/1961023002/diff/1/chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm#newcode39 chrome/browser/ui/cocoa/passwords/autosignin_prompt_view_controller.mm:39: @property (nonatomic, copy) BOOL (^escHandler)(NSEvent* theEvent); On 2016/05/09 11:16:17, ...
4 years, 7 months ago (2016-05-09 11:45:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1961023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1961023002/20001
4 years, 7 months ago (2016-05-09 11:46:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-09 12:13:39 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 12:15:24 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d237e3b85e855b9620ba3e94df06095ad3ecc07
Cr-Commit-Position: refs/heads/master@{#392298}

Powered by Google App Engine
This is Rietveld 408576698