Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1991723003: [turbofan] Hide escape analysis internals from interface. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Hide escape analysis internals from interface. This is pure refactoring that moves many internal details of the escape analysis from the header into the compilation unit. The goal of this is to simplify the interface for readability. R=jarin@chromium.org Committed: https://crrev.com/84a8e817a5227600c147ddd454856072f246c250 Cr-Commit-Position: refs/heads/master@{#36322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -138 lines) Patch
M src/compiler/escape-analysis.h View 3 chunks +11 lines, -110 lines 0 comments Download
M src/compiler/escape-analysis.cc View 15 chunks +121 lines, -28 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-18 12:07:50 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-18 13:38:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1991723003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1991723003/1
4 years, 7 months ago (2016-05-18 13:41:41 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 13:43:37 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 13:45:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/84a8e817a5227600c147ddd454856072f246c250
Cr-Commit-Position: refs/heads/master@{#36322}

Powered by Google App Engine
This is Rietveld 408576698