Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 1989243002: [turbofan] Remove verbose escape analysis helper methods. (Closed)

Created:
4 years, 7 months ago by Michael Starzinger
Modified:
4 years, 7 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@local_turbofan-escape-refactor-hide
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove verbose escape analysis helper methods. This is a pure refactoring that removes unnecessary wrapper methods from the EscapeAnalysis class. This completely removes the notion of "Alias" from the interface. R=jarin@chromium.org Committed: https://crrev.com/6046e4a10a00cf2cc50d32754a4cb839cb881d35 Cr-Commit-Position: refs/heads/master@{#36325}

Patch Set 1 #

Patch Set 2 : Fix think'o. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -70 lines) Patch
M src/compiler/escape-analysis.h View 3 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/escape-analysis.cc View 1 16 chunks +32 lines, -61 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
Michael Starzinger
4 years, 7 months ago (2016-05-18 12:12:16 UTC) #1
Jarin
lgtm
4 years, 7 months ago (2016-05-18 13:39:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1989243002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1989243002/20001
4 years, 7 months ago (2016-05-18 14:02:14 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-18 14:04:16 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 14:05:55 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6046e4a10a00cf2cc50d32754a4cb839cb881d35
Cr-Commit-Position: refs/heads/master@{#36325}

Powered by Google App Engine
This is Rietveld 408576698