Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7107)

Unified Diff: appengine/findit/common/waterfall/buildbucket_client.py

Issue 1991333002: [Findit] Send targeted_tests to try-job in build_parameter instend of build_property (Findit side). (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/common/waterfall/buildbucket_client.py
diff --git a/appengine/findit/common/waterfall/buildbucket_client.py b/appengine/findit/common/waterfall/buildbucket_client.py
index 48468968a46666686bac2cf839ddcfa320de9516..c8f525f28f17abd0b1f0af60bdbe93b8c37f2f07 100644
--- a/appengine/findit/common/waterfall/buildbucket_client.py
+++ b/appengine/findit/common/waterfall/buildbucket_client.py
@@ -34,7 +34,8 @@ def _GetBucketName(master_name):
class TryJob(collections.namedtuple(
'TryJobNamedTuple',
- ('master_name', 'builder_name', 'revision', 'properties', 'tags'))):
+ ('master_name', 'builder_name', 'revision', 'properties', 'tags', 'tests'))
stgao 2016/05/20 05:15:48 How about making this generic enough for other cha
+):
"""Represents a try-job to be triggered through Buildbucket.
Tag for "user_agent" should not be set, as it will be added automatically.
@@ -45,6 +46,8 @@ class TryJob(collections.namedtuple(
'builder_name': self.builder_name,
'properties': self.properties,
}
+ if self.tests:
+ parameters_json['tests'] = self.tests
if self.revision:
parameters_json['changes'] = [
{

Powered by Google App Engine
This is Rietveld 408576698