Chromium Code Reviews| Index: appengine/findit/waterfall/schedule_try_job_pipeline.py |
| diff --git a/appengine/findit/waterfall/schedule_try_job_pipeline.py b/appengine/findit/waterfall/schedule_try_job_pipeline.py |
| index e157d7a36b3c8494fb4be6408acdf1375d13952f..21b1add23908872662dc2e36fdad74e3ec01061a 100644 |
| --- a/appengine/findit/waterfall/schedule_try_job_pipeline.py |
| +++ b/appengine/findit/waterfall/schedule_try_job_pipeline.py |
| @@ -17,8 +17,7 @@ class ScheduleTryJobPipeline(BasePipeline): |
| def _GetBuildProperties( |
| self, master_name, builder_name, build_number, good_revision, |
| - bad_revision, try_job_type, compile_targets, targeted_tests, |
| - suspected_revisions): |
| + bad_revision, try_job_type, compile_targets, suspected_revisions): |
| properties = { |
| 'recipe': 'findit/chromium/%s' % try_job_type, |
| 'good_revision': good_revision, |
| @@ -34,8 +33,6 @@ class ScheduleTryJobPipeline(BasePipeline): |
| properties['compile_targets'] = compile_targets |
| else: # try_job_type is 'test'. |
| properties['target_testername'] = builder_name |
| - assert targeted_tests |
| - properties['tests'] = targeted_tests |
| if suspected_revisions: |
| properties['suspected_revisions'] = suspected_revisions |
| @@ -53,10 +50,13 @@ class ScheduleTryJobPipeline(BasePipeline): |
| properties = self._GetBuildProperties( |
| master_name, builder_name, build_number, good_revision, bad_revision, |
| - try_job_type, compile_targets, targeted_tests, suspected_revisions) |
| + try_job_type, compile_targets, suspected_revisions) |
| + if try_job_type == TryJobType.COMPILE: |
| + targeted_tests = {} |
|
lijeffrey
2016/05/20 20:44:41
nit: add 1 newline after this
|
| try_job = buildbucket_client.TryJob( |
| - tryserver_mastername, tryserver_buildername, None, properties, []) |
| + tryserver_mastername, tryserver_buildername, None, properties, |
| + targeted_tests, []) |
| error, build = buildbucket_client.TriggerTryJobs([try_job])[0] |
| if error: # pragma: no cover |