third_party/WebKit/Source/core/page/Page.cpp - Issue 1991273003: Fire visibilityChange event on out-of-process iframes.

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/render_view_impl.cc ('K') | « content/renderer/render_view_impl.cc ('k') | third_party/WebKit/Source/web/WebFrameWidgetImpl.h » ('j') | third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/Page.cpp

diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp

index 0ae0ab8d4573026765ff80b967787317550b4104..a29c17ba7db2c301814acc3271b08ea64a726865 100644

--- a/third_party/WebKit/Source/core/page/Page.cpp

+++ b/third_party/WebKit/Source/core/page/Page.cpp

@@ -358,8 +358,8 @@ void Page::setVisibilityState(PageVisibilityState visibilityState, bool isInitia

if (!isInitialState)

notifyPageVisibilityChanged();

- if (!isInitialState && m_mainFrame && m_mainFrame->isLocalFrame())

- deprecatedLocalMainFrame()->didChangeVisibilityState();

+ if (!isInitialState && m_mainFrame)

+ m_mainFrame->didChangeVisibilityState();

kenrb 2016/05/24 20:25:18 How does this not crash in an OOPIF renderer?

kenrb 2016/05/24 20:33:20 Never mind, I just looked at this a bit closer. Th

lfg 2016/05/24 23:33:51 Right, Daniel moved that block from LocalFrame to

kenrb 2016/05/25 20:29:14 As an aside, related to a discussion we had on thi

lfg 2016/05/31 19:54:01 Acknowledged.

// Compress CompressibleStrings when 10 seconds have passed since the page

// went to background.