Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp

Issue 1991273003: Fire visibilityChange event on out-of-process iframes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
index cc5d4b7645afc52547288c9a68e05182c15ecad1..d2edbbdffc8b6642d3f45b4790dad0e4aa2349e7 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp
@@ -1071,21 +1071,10 @@ void WebFrameWidgetImpl::detachCompositorAnimationTimeline(CompositorAnimationTi
m_layerTreeView->detachCompositorAnimationTimeline(compositorTimeline->animationTimeline());
}
-void WebFrameWidgetImpl::setVisibilityState(WebPageVisibilityState visibilityState, bool isInitialState)
+void WebFrameWidgetImpl::setVisibilityState(WebPageVisibilityState visibilityState)
{
- if (!page())
- return;
-
- // FIXME: This is not correct, since Show and Hide messages for a frame's Widget do not necessarily
- // correspond to Page visibility, but is necessary until we properly sort out OOPIF visibility.
- page()->setVisibilityState(static_cast<PageVisibilityState>(visibilityState), isInitialState);
-
- m_localRoot->frame()->frameScheduler()->setPageVisible(visibilityState == WebPageVisibilityStateVisible);
-
- if (m_layerTreeView) {
- bool visible = visibilityState == WebPageVisibilityStateVisible;
- m_layerTreeView->setVisible(visible);
- }
+ if (m_layerTreeView)
kenrb 2016/05/24 20:25:18 Why is it okay to remove the call to WebFrameSched
lfg 2016/05/24 23:33:51 This is already done in WebViewSchedulerImpl::setP
kenrb 2016/05/25 20:29:14 Acknowledged. This is fine, although I notice that
lfg 2016/05/31 19:54:01 That's right. However, if we do that here, the cor
+ m_layerTreeView->setVisible(visibilityState == WebPageVisibilityStateVisible);
}
HitTestResult WebFrameWidgetImpl::hitTestResultForRootFramePos(const IntPoint& posInRootFrame)

Powered by Google App Engine
This is Rietveld 408576698