chrome/browser/extensions/extension_util.cc - Issue 1991263003: Enables EXTERNAL_COMPONENT extensions in incognito by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_util.cc

Issue 1991263003: Enables EXTERNAL_COMPONENT extensions in incognito by default. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert tab_capture changes Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/extension_util.cc

diff --git a/chrome/browser/extensions/extension_util.cc b/chrome/browser/extensions/extension_util.cc

index 4a861653b6ebb4e3906532324f16a8e501d3f259..75c7c213add0b53641bb65c4b23dc586c9080c30 100644

--- a/chrome/browser/extensions/extension_util.cc

+++ b/chrome/browser/extensions/extension_util.cc

@@ -126,7 +126,8 @@ bool IsIncognitoEnabled(const std::string& extension_id,

return false;

// If this is an existing component extension we always allow it to

// work in incognito mode.

- if (extension->location() == Manifest::COMPONENT)

+ if (extension->location() == Manifest::COMPONENT ||

+ extension->location() == Manifest::EXTERNAL_COMPONENT)

benwells 2016/05/23 01:51:19 Nit: please add braces now your condition spans tw

mark a. foltz 2016/05/23 22:08:13 Done.

return true;

if (IsWhitelistedForIncognito(extension))

return true;

« no previous file with comments | « no previous file | no next file » | no next file with comments »