Enables EXTERNAL_COMPONENT extensions in incognito by default.

chrome/browser/extensions/extension_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_util.h"
 
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/values.h"
@@ skipping 108 matching lines @@
 
 bool IsIncognitoEnabled(const std::string& extension_id,
                         content::BrowserContext* context) {
   const Extension* extension = ExtensionRegistry::Get(context)->
       GetExtensionById(extension_id, ExtensionRegistry::ENABLED);
   if (extension) {
     if (!util::CanBeIncognitoEnabled(extension))
       return false;
     // If this is an existing component extension we always allow it to
     // work in incognito mode.
-    if (extension->location() == Manifest::COMPONENT)
+    if (extension->location() == Manifest::COMPONENT ||
+        extension->location() == Manifest::EXTERNAL_COMPONENT)

[benwells, 2016/05/23 01:51:19]

Nit: please add braces now your condition spans two lines.

[mark a. foltz, 2016/05/23 22:08:13]

Done.

       return true;
     if (IsWhitelistedForIncognito(extension))
       return true;
   }
   return ExtensionPrefs::Get(context)->IsIncognitoEnabled(extension_id);
 }
 
 void SetIsIncognitoEnabled(const std::string& extension_id,
                            content::BrowserContext* context,
                            bool enabled) {
@@ skipping 249 matching lines @@
   base::FieldTrialList::FindFullName(
       kSupervisedUserExtensionPermissionIncreaseFieldTrialName);
   std::string value = variations::GetVariationParamValue(
       kSupervisedUserExtensionPermissionIncreaseFieldTrialName,
       profile->IsChild() ? "child_account" : "legacy_supervised_user");
   return value == "true";
 }
 
 }  // namespace util
 }  // namespace extensions