Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: chrome/browser/extensions/api/terminal/terminal_private_api.cc

Issue 1991083002: Remove ExtensionFunction::SetResult(T*) overload. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: IWYU Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/terminal/terminal_private_api.cc
diff --git a/chrome/browser/extensions/api/terminal/terminal_private_api.cc b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
index 8dd7ee6f4a19c704a393709c8457fa56b0656e7d..a60623839edd34122085e174afa6344e4e1b1c76 100644
--- a/chrome/browser/extensions/api/terminal/terminal_private_api.cc
+++ b/chrome/browser/extensions/api/terminal/terminal_private_api.cc
@@ -8,6 +8,7 @@
#include "base/bind.h"
#include "base/json/json_writer.h"
+#include "base/memory/ptr_util.h"
#include "base/sys_info.h"
#include "base/values.h"
#include "chrome/browser/extensions/api/terminal/terminal_extension_helper.h"
@@ -169,7 +170,7 @@ void TerminalPrivateOpenTerminalProcessFunction::RespondOnUIThread(
SendResponse(false);
return;
}
- SetResult(new base::FundamentalValue(terminal_id));
+ SetResult(base::MakeUnique<base::FundamentalValue>(terminal_id));
SendResponse(true);
}
@@ -197,7 +198,7 @@ void TerminalPrivateSendInputFunction::SendInputOnFileThread(
}
void TerminalPrivateSendInputFunction::RespondOnUIThread(bool success) {
- SetResult(new base::FundamentalValue(success));
+ SetResult(base::MakeUnique<base::FundamentalValue>(success));
SendResponse(true);
}
@@ -232,7 +233,7 @@ void TerminalPrivateCloseTerminalProcessFunction::CloseOnFileThread(
void TerminalPrivateCloseTerminalProcessFunction::RespondOnUIThread(
bool success) {
- SetResult(new base::FundamentalValue(success));
+ SetResult(base::MakeUnique<base::FundamentalValue>(success));
SendResponse(true);
}
@@ -266,7 +267,7 @@ void TerminalPrivateOnTerminalResizeFunction::OnResizeOnFileThread(
}
void TerminalPrivateOnTerminalResizeFunction::RespondOnUIThread(bool success) {
- SetResult(new base::FundamentalValue(success));
+ SetResult(base::MakeUnique<base::FundamentalValue>(success));
SendResponse(true);
}

Powered by Google App Engine
This is Rietveld 408576698